Update GIN

[fengxie009]

[tofuwen]

BTW, for every PR, we should have an informative description.

Could you add your description? Here is a good example PR with great descriptions: https://github.com/cmu-phil/causal-learn/pull/85

[fengxie009]

Updates

Modified the whole GIN package to make it more readable

1. GIN.py: GIN(data, indep_test_method='kci', alpha=0.05, MAX_Factor = 2) The MAX_Factor parameter is added to make the GIN algorithm more efficient

Notes Please kindly note that the GIN method highly relies on the independent test, e.g., KCI or HSIC. Please try to modify the default parameters in the independent test method, such as kernel width, when the GIN method can not output any information.

[tofuwen]

Basically add description there. People will tend to read the first block, but not the conversions (because it's too much)

So in industry (or open-sourced project), it's a good practice to have great descriptions in the first cell.

[kunwuz]

Hi all @fengxie009 @tofuwen, just would like to quickly check whether there are any updates on this PR. Please feel free to let others know if there are any questions :)

[fengxie009]

Hi Yujia,

There are currently no updates. I will let you know if there are any changes.

Best wishes, Feng

Yujia Zheng @.***> 于2023年1月31日周二 08:10写道：

Hi all @fengxie009 https://github.com/fengxie009 @tofuwen https://github.com/tofuwen, just would like to quickly check whether there are any updates on this PR. Please feel free to let others know if there are any questions :)

— Reply to this email directly, view it on GitHub https://github.com/py-why/causal-learn/pull/87#issuecomment-1409551896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6YBRX2AGGKIDDJIR5YJPLWVBKAJANCNFSM6AAAAAASWHV7YU . You are receiving this because you were mentioned.Message ID: @.***>

[tofuwen]

Hi @fengxie009,

Do we have some updates here? :)

We need to ensure that we have unit tests coverage for all the methods, as it's required here: https://github.com/py-why/causal-learn/issues/100

And we will build the CI once your unit tests are completed. :)

[kunwuz]

Hi @fengxie009 and @tofuwen, are there any updates on this PR? I believe some quick tests to make sure that the modification is correct is enough to merge this. It seems to be around too long.