EconML icon indicating copy to clipboard operation
EconML copied to clipboard

Issue with #791: Missing data allowed when training, but not inferencing

Open esbraun opened this issue 2 years ago • 9 comments

#791 ought to allow missing data when inferencing if allow_missing = True, but currently an error is thrown when the inference data includes missing data. RE: below for a working example based on the "Metalearner Examples" notebook for a demonstration of the issue.

https://colab.research.google.com/drive/1QT-IdwRWRUiQNDwqJ0EXPXSftDuIg3uE?usp=sharing

esbraun avatar Nov 08 '23 22:11 esbraun

I'm seeing the same issue

Ftrejo23 avatar Nov 14 '23 22:11 Ftrejo23

Thanks for raising this issue. In the original PR we originally only considered missing data during training, but it seems there is interest in extending this to inferencing as well.

fverac avatar Nov 16 '23 00:11 fverac

Hi there, just wondering if there any update on this as running into the same problems (doesn't allow missing values when computing CATE/ATE).

erasedcitizen11 avatar Aug 05 '24 16:08 erasedcitizen11

@erasedcitizen11 I created a fork that disables the missing value checks which is a requirement for our use cases. Use at your own risk: https://github.com/esbraun/EconML/tree/main

esbraun avatar Aug 05 '24 16:08 esbraun