EconML icon indicating copy to clipboard operation
EconML copied to clipboard

PEP 517 support

Open Zethson opened this issue 2 years ago • 3 comments

We have a build failure over at dowhy when upgrading statsmodels due to

Note: This error originates from the build backend, and is likely not a problem with poetry but with econml (0.13.0) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "econml (==0.13.0)"'.

Source: https://github.com/py-why/dowhy/pull/997

Zethson avatar Jul 28 '23 22:07 Zethson

My guess is that the build system and stuff might need to be specified in the pyproject.toml

Zethson avatar Jul 28 '23 22:07 Zethson

Would be great to have more information on exactly what commands you were running when you saw this, as well as what versions of python and pip you're using and what packages you currently have installed.

Based on https://github.com/python-poetry/poetry/issues/8207 I suspect the issue is actually that we don't support Cython 3, which has already been addressed in a PR but not any release.

kbattocchi avatar Jul 28 '23 22:07 kbattocchi

Sure! I can only see this in the dowhy CI :) You'll have to look there. https://github.com/py-why/dowhy/actions/runs/5696627297/job/15442067622?pr=997

That's:

  1. Python 3.11
  2. Poetry 1.51
  3. pip 23.2.1

I adapted the statsmodels version in dowhy, ran poetry lock and pushed. The CI is now trying to install econml which is required for some tests and then it dies.

Zethson avatar Jul 28 '23 22:07 Zethson