EconML icon indicating copy to clipboard operation
EconML copied to clipboard

Consistent notation for learner APIs

Open EgorKraevTransferwise opened this issue 3 years ago • 1 comments

Would it be possible to harmonize the notation across the different learners? For example, the treatment propensity model is referred to as model_t in CausalForest, model_T in DMLOrthoForest, propensity_model in XLearner, and as model_propensity in ForestDRLearner. Same for model_y, etc

That introduces confusion and complicates code reuse, for no good reason that I can see.

EgorKraevTransferwise avatar Dec 31 '21 11:12 EgorKraevTransferwise

This is a good suggestion - thanks. I don't see any reason not to harmonize these.

kbattocchi avatar Jan 03 '22 16:01 kbattocchi