EconML icon indicating copy to clipboard operation
EconML copied to clipboard

Relax tensorflow version limit

Open kbattocchi opened this issue 4 years ago • 7 comments

kbattocchi avatar Jan 28 '21 02:01 kbattocchi

@kbattocchi Looks like this might fix the DeepIV implementation! need a hand pushing it over the finish line?

akelleh avatar Mar 16 '21 22:03 akelleh

@akelleh Yes, that would be great! Thanks for the offer.

kbattocchi avatar Mar 17 '21 17:03 kbattocchi

I'll make some time this weekend, if you don't get to it before me!

akelleh avatar Mar 18 '21 17:03 akelleh

@akelleh Yes, that would be great! Thanks for the offer.

Having some trouble even getting tests running... Following the build instructions on the main page in a new virtualenv (python setup.py develop with an updated setuptools), python setup.py pytest just returns error: invalid command 'pytest'. Any trick to make this work?

akelleh avatar Mar 20 '21 16:03 akelleh

Whoops, sorry - looks like we haven't updated the docs after restructuring our package a bit. Try:

pip install -e .[tf,plt]
pip install pytest-runner
python setup.py pytest

kbattocchi avatar Mar 20 '21 17:03 kbattocchi

You should also set the environment variable PYTEST_ADDOPTS to -m "not (notebook or automl or dml)" so that you're not running a bunch of tests that are unimpacted (and in the case of the notebook and automl tests, have additional dependencies).

kbattocchi avatar Mar 20 '21 17:03 kbattocchi

You should also set the environment variable PYTEST_ADDOPTS to -m "not (notebook or automl or dml)" so that you're not running a bunch of tests that are unimpacted (and in the case of the notebook and automl tests, have additional dependencies).

Thanks! Will do. I'm taking your PR for a spin now -- so far so good!

akelleh avatar Mar 20 '21 18:03 akelleh