sherlock

sherlock copied to clipboard

Use `extra_requires` for the backend clients pip

3

Suggestion: Instead of requiring all 3 backend clients to be installed, please allow an option to only install the backend being used. Relevant: https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies

kalyanaramansanthanam

This backend uses Kubernetes' Lease object to implement locking. This is useful for applications deployed to Kubernetes as it removes the need for additional infrastructure to be deployed (ie. Redis,...

judahrand

The fix from #32 is not in the latest published version

4

please see the conversation in #32 - the fix from there did not make it into the 0.3.2 release. Please rebuild the release and bump the version number

aausch

Hi I would like to add postgresql as backend by using Advisory Locks (https://www.postgresql.org/docs/12/explicit-locking.html#ADVISORY-LOCKS) Can someone point me the how can I do this? Just point me the simplest lock...

iuridiniz

Having consul backend would be really nice to have :)

pySilver

[fix] error message on lock release

2

https://github.com/vaidik/sherlock/issues/40

vishalkanaujia

The current error message ``` raise LockException('Lock could not be released because it ' 'was been acquired by this instance.') ``` It should be ``` raise LockException('Lock could not be...

vishalkanaujia

I'm willing to make the change and submit PR but I noticed it was very easy to successfully run test suite with `PYTHON_VERSION=3 make test` for example, yet the README...

evictor

If no expiration is set on locks, don't expire them

1

probably the expected behavior when expiration values are not set, is for Locks to last until they're released? Currently they're immediately expired (i.e. not set at all), and this change...

aausch

show build status on master, not latest commit

1

AlexRiina