pypdf icon indicating copy to clipboard operation
pypdf copied to clipboard

BUG: _read_inline_image infinite loop

Open yuvalgtrustmi opened this issue 1 year ago • 5 comments

fixes https://github.com/py-pdf/pypdf/issues/2423

yuvalgtrustmi avatar Jan 23 '24 17:01 yuvalgtrustmi

Thanks for the PR. Are you able to provide a corresponding test which ensures that this will not break again in the future?

stefan6419846 avatar Jan 23 '24 19:01 stefan6419846

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.49%. Comparing base (54ae0a6) to head (ad9ad7c). Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2424      +/-   ##
==========================================
+ Coverage   94.43%   94.49%   +0.06%     
==========================================
  Files          49       49              
  Lines        8008     8180     +172     
  Branches     1616     1660      +44     
==========================================
+ Hits         7562     7730     +168     
- Misses        276      278       +2     
- Partials      170      172       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 28 '24 06:01 codecov[bot]

@yuvalgtrustmi Are you still interested in working on this PR and adding corresponding tests?

stefan6419846 avatar Feb 25 '24 18:02 stefan6419846

@yuvalgtrustmi I've produced a Pdf where the content has been cut 3 parts with one "subcontent" with only EI: EI_isolated_in_content.pdf however I can find how to reproduce your issue. Can you provide the code you've used to initially produce the error

pubpub-zz avatar Feb 25 '24 20:02 pubpub-zz

@yuvalgtrustmi any update?

pubpub-zz avatar Feb 28 '24 19:02 pubpub-zz

@yuvalgtrustmi any update?

any update ? On my side I can not reproduce the issue

pubpub-zz avatar Mar 17 '24 19:03 pubpub-zz

@yuvalgtrustmi can you please provide the failing code

pubpub-zz avatar Mar 18 '24 09:03 pubpub-zz

@yuvalgtrustmi last request before closing the PR for cleanup. It can be reopened later

pubpub-zz avatar Mar 30 '24 08:03 pubpub-zz

I close this PR and associated issue for clean-up.feel free to ask to reopen it if you have more data

pubpub-zz avatar Apr 06 '24 07:04 pubpub-zz