pypdf icon indicating copy to clipboard operation
pypdf copied to clipboard

STY: Same attributes between PdfReader and PdfWriter

Open pubpub-zz opened this issue 1 year ago • 4 comments

provides the same interface to access root,info,id for communalisation The objective is prepare some code factorization between PdfWriter / PdfReader

pubpub-zz avatar Jun 04 '23 17:06 pubpub-zz

Codecov Report

Patch coverage: 98.94% and project coverage change: +0.11 :tada:

Comparison is base (8dbd82c) 93.42% compared to head (7b102b7) 93.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   93.42%   93.54%   +0.11%     
==========================================
  Files          34       34              
  Lines        6634     6627       -7     
  Branches     1303     1297       -6     
==========================================
+ Hits         6198     6199       +1     
+ Misses        284      281       -3     
+ Partials      152      147       -5     
Impacted Files Coverage Δ
pypdf/_protocols.py 100.00% <ø> (ø)
pypdf/_writer.py 87.84% <98.18%> (+0.19%) :arrow_up:
pypdf/_page_labels.py 97.61% <100.00%> (ø)
pypdf/_reader.py 91.27% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 04 '23 17:06 codecov[bot]

@pubpub-zz This PR is open for quite a while. Is it still relevant?

MartinThoma avatar Aug 13 '23 07:08 MartinThoma

Yes I need to complete it a little to isolate some common code : this will ease maintenance and allow to get some PdfReader only functions into PdfWriter

pubpub-zz avatar Aug 13 '23 07:08 pubpub-zz

No problem. I didn't intend to put pressure on you. I just wanted to ensure that I don't forget PRs :-)

MartinThoma avatar Aug 13 '23 13:08 MartinThoma

closed : rewritten in #2495

pubpub-zz avatar Mar 02 '24 17:03 pubpub-zz