Diagrams for all commands
Fixes https://github.com/py-pdf/pdfly/issues/178
Checklist:
-
[ ] A unit test is covering the code added / modified by this PR
-
[ ] In case of a new feature, docstrings have been added, with also some documentation in the
docs/folder -
[ ] A mention of the change is present in
CHANGELOG.md -
[ ] This PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD 3-Clause license.
That is very nice!
What do you think about moving them into docs + adding the drawio source file so that others can easily make adjustments?
Good job ๐
What do you think about moving them into
docs+ adding the drawio source file so that others can easily make adjustments?
I fully agree with @MartinThoma ๐
Also, after that you should be able to insert a reference to the PNG images in the corresponding Markdown files for the subcommands.
Okay so do i have to add diagrams of all commands or just 2-up command and booklet command @Lucas-C??
Okay so do i have to add diagrams of all commands or just 2-up command and booklet command @Lucas-C??
Given that you already made diagrams for all commands, you can insert an image in all subcommands Markdown pages where you created on ๐
Hi @d-mahi14
I see you added a new commit to this PR, but I'm afraid my request was misunderstood:
- no need to introduce a new
docs/commands.mdfile, images should be inserted in the existingdocs/user/subcommand*.mdfiles - please don't insert images in Markdown files using a
data:prefix. Use the standard syntax to embed images by referencing a file in the repository: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#images
Out of curiosity, are you new to open source contributions and/or programming?
I totally understand if you don't know much currently about Markdown / git / etc.
I would be happy to help so please ask questions if need be ๐
Yess am new to hacktoberfestโฆI got the subcommand.md file will work on it now
On Wed, 15 Oct 2025 at 11:46โฏAM, Lucas Cimon @.***> wrote:
Lucas-C left a comment (py-pdf/pdfly#186) https://github.com/py-pdf/pdfly/pull/186#issuecomment-3404714192
Hi @d-mahi14 https://github.com/d-mahi14
I see you added a new commit to this PR, but I'm afraid my request was misunderstood:
- no need to introduce a new docs/commands.md file, images should be inserted in the existing docs/user/subcommand*.md files
- please don't insert images in Markdown files using a data: prefix. Use the standard syntax to embed images by referencing a file in the repository: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#images
Out of curiosity, are you new to open source contributions and/or programming? I totally understand if you don't know much currently about Markdown / git / etc. I would be happy to help so please ask questions if need be ๐
โ Reply to this email directly, view it on GitHub https://github.com/py-pdf/pdfly/pull/186#issuecomment-3404714192, or unsubscribe https://github.com/notifications/unsubscribe-auth/BPSCKHMU7GKZYGVZ5GN4F4D3XXRDZAVCNFSM6AAAAACJCE7GE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBUG4YTIMJZGI . You are receiving this because you were mentioned.Message ID: @.***>
please review it again @Lucas-C
Hi ๐ ๐ We are close to the end of the month, I was just curious to know if you were willing to finish this PR as part of Hacktoberfest?