mcstatus
mcstatus copied to clipboard
py-mine
Resolve TODO about Mac OS failing tests
This actually applied to multiple operating systems, but required using a DNS server that answers to queries about localhost. Responding to those with anything but NXDOMAIN violates the DNS RFC, so it's surprising to see this be so rampant out in the wild. Anyway, the solution is to use getaddrinfo to let the OS stack handle resolution of names.
The
Address.resolve_ipfunction and the async counterpart can now probably be removed completely, since they were only really relevant for UDP connections which required an IP, but that's no longer the case here.
I had the same idea. Seeing as how we just released those, maybe it's not too late to take those out from the public API without any deprecation period.
If it's done, could you please make it ready for review?
Mac OS tests still failed in CI, and I haven't looked at why yet.
The ConnectionResetError is interesting. The exact same thing happened during tox-test (macos-latest, 3.8) in PR #273, but when I triggered it again, everything passed. This might be something to look deeper into, because it seems like something similar happened on Windows from time to time in the past. Original find: https://github.com/py-mine/mcstatus/issues/140
Failed run: https://github.com/py-mine/mcstatus/runs/7371481344?check_suite_focus=true#step:6:275
Success run: https://github.com/py-mine/mcstatus/runs/7371820372?check_suite_focus=true#step:6:141
Change between runs: https://github.com/py-mine/mcstatus/pull/273/commits/3dcd296c7434675493f7e9bfb485894e55005f98
