mcproto
mcproto copied to clipboard
More types
Depends on #285 New Serializable (v3)
All the types described in the list on Wiki.vg are now implemented and fully tested.
Thank you for the review, I'm about to commit my changes but should I add the new types I wrote for the packets ?
The current PR contains everything listed on the top of the "Current protocol" page, but there are some types missing that I noticed and implemented later.
Oh, well, if the types are needed by some packets then yeah add them, if not, why are they even useful for us?
They are defined later in the page, or on other page, it's a bit of a mess (like the whole brigadier for example, or the Trade format, the crafting recipe type, ...)
The PR diff size of 21048 lines exceeds the maximum allowed for the inline comments feature.
Don't worry buddy, it's gonna be alright.
Marking as draft to give me time to use NamedTuples when it's needed
Thing left to do before merging :
- [x] Use attrs validators instead of the validate function
- [x] Use converters when applicable
- [x] Get some actual data on the NBT serialization process
I didn't manage to check the NBT for myself in this particular case but I was able to extract some packets and verify that they do not include the name tag, as stated in the documentation.
I re-ran the tests with basedpyright, everything seems fine
Shouldn't this get merged ?
Ok great, I have been a little busy too. I'll try to make the changes soon !