mcproto icon indicating copy to clipboard operation
mcproto copied to clipboard

More types

Open LiteApplication opened this issue 1 year ago • 10 comments

Depends on #285 New Serializable (v3)

All the types described in the list on Wiki.vg are now implemented and fully tested.

LiteApplication avatar May 17 '24 14:05 LiteApplication

Thank you for the review, I'm about to commit my changes but should I add the new types I wrote for the packets ?

The current PR contains everything listed on the top of the "Current protocol" page, but there are some types missing that I noticed and implemented later.

LiteApplication avatar Jun 13 '24 15:06 LiteApplication

Oh, well, if the types are needed by some packets then yeah add them, if not, why are they even useful for us?

ItsDrike avatar Jun 13 '24 16:06 ItsDrike

They are defined later in the page, or on other page, it's a bit of a mess (like the whole brigadier for example, or the Trade format, the crafting recipe type, ...)

LiteApplication avatar Jun 13 '24 16:06 LiteApplication

The PR diff size of 21048 lines exceeds the maximum allowed for the inline comments feature.

Don't worry buddy, it's gonna be alright.

LiteApplication avatar Jun 18 '24 16:06 LiteApplication

Marking as draft to give me time to use NamedTuples when it's needed

LiteApplication avatar Jun 18 '24 16:06 LiteApplication

Thing left to do before merging :

  • [x] Use attrs validators instead of the validate function
  • [x] Use converters when applicable
  • [x] Get some actual data on the NBT serialization process

LiteApplication avatar Jun 18 '24 23:06 LiteApplication

I didn't manage to check the NBT for myself in this particular case but I was able to extract some packets and verify that they do not include the name tag, as stated in the documentation.

LiteApplication avatar Jul 08 '24 09:07 LiteApplication

I re-ran the tests with basedpyright, everything seems fine

LiteApplication avatar Jul 12 '24 14:07 LiteApplication

Shouldn't this get merged ?

LiteApplication avatar Aug 29 '24 21:08 LiteApplication

Ok great, I have been a little busy too. I'll try to make the changes soon !

LiteApplication avatar Sep 03 '24 05:09 LiteApplication