PyMine-Server
PyMine-Server copied to clipboard
Config cleanup
Feature
- Config should be sorted by category(rcon, query, world, etc)->alphabetically, with comments describing each section. Comment can be achieved with ruamel.yaml
Reason
- The config should be mainly self-explanatory to new users. This also stops noob devs like me from spamming petus for help quite as often.
I'd like to help out but I'm not too familiar with creating servers or Minecraft, and this is what I think how categories should look:
- server/rcon: -- debug -- level_name -- server_ip -- server_port -- gamemode -- max_players -- pvp -- hardcore -- motd -- online_mode -- white_list -- spawn_protection
- world -- generator -- spawn_npcs -- spawn_monsters -- spawn_animals -- seed
- player -- view_distance
- query -- enable_query -- query_port -- prompt
- other -- vi_mode -- comp_thresh
Pls correct me if I'm wrong (which I probably am) I'd also suggest changing the location of configs (and addition of a default .yaml file) to at least be in the same directory as main if not in the same directory as the startserver scripts, so that users don't have to dig for it (this requires a change in config.py though, to go one or two directories up which can be solved using something like this https://stackoverflow.com/questions/4381569/python-os-module-open-file-above-current-directory-with-relative-path)
additonally i think that it should parse arguments for the location etc like the java equivilant does
There's a couple issues with this, the PyYAML package doesn't support having ordered dictionary entries, and the server.yml
is already in the parent directory?