Pooya Salehi
Pooya Salehi
@henningandersen @original-brownbear Thank you for the reviews. Please have another look. I've addressed all comments. I haven't added that case in Henning's code sample where we spawn directly if workers...
(Test failure doesn't seem to be related to the PR: https://github.com/elastic/elasticsearch/issues/89623)
@elasticmachine run elasticsearch-ci/part-1
@elasticmachine update branch (There is a fix to one of the Snapshot ITs in main that was failing also in this PR)
I looked into the [previous failures](https://gradle-enterprise.elastic.co/s/lpiy4ql6ecvxc/tests/:server:internalClusterTest/org.elasticsearch.snapshots.CloneSnapshotIT/testRemoveFailedCloneFromCSWithQueuedSnapshotInProgress?top-execution=1), since they were both related to snapshotting. From the previous test failures, it seems `ConcurrentSnapshotsIT.testMasterFailoverOnFinalizationLoop` was failing due to recent changes on main, and...
@henningandersen Thanks for the detailed feedback. I addressed all your comments. Please have another look. Meanwhile I'll look into that previous CI failure to see if it is related or...
> @henningandersen Thanks for the detailed feedback. I addressed all your comments. Please have another look. Meanwhile I'll look into that previous CI failure to see if it is related...
@original-brownbear @henningandersen All done! Please check again.
Thanks Henning and Armin!
@elasticmachine update branch