Pedro Martins

Results 390 comments of Pedro Martins

Hello @Areso . I was just wondering about github (i searched travian) and found your project. Nice work man :) If you would like to speedup your backend implementation checkout:...

Hi @ArlonAntonius . This still an issue. If I cache my routes the tenant routes does not work. Best, Pedro

Hello @jorgetwgroup once again, thanks for the review. I've just pushed a fix for the scenario you found failing: losing selected rows when navigating pages. Please note that if you...

Hey @jorgetwgroup once again, nice catch! I think I've now covered all the scenarios 🤞 😨 There is one business rule that is now added: - If you filter the...

Hey @jorgetwgroup all spaces in code review addressed. I am moving this to ready to merge since your last review you said everything is working fine. Cheers

If this gets merged #3932 should be closed!

@tabacitu I merged the changes regarding the comments in doc blocks. Thanks 👍 Also commented about the method signature: https://github.com/Laravel-Backpack/CRUD/pull/4271#discussion_r841569036 Let me know if I didn't explain myself well 🙃...

@tabacitu kindly review the changes 👍 I've refactored method signatures and cleaned up the functions.

@jorgetwgroup I've been testing this for a while. Please can you confirm my findings? - If I have developer console open, clearing the browser cache on refresh I don't get...

Hey guys. What @jorgetwgroup found out is also happening in the main branch, and I am not sure there is an easy way to fix it. We can reproduce this...