Aditya Keerthi

> (also, what does Nit mean?) Short for "nitpick".

> I've added the test, based on how it was done in the text/plain change. One question I have about this is wether it is expected that the testrunner _always_...

You need [committer access](https://webkit.org/commit-and-review-policy/) to merge, which requires ~10 commits and a nomination. I was waiting on tests to finish running, and they have, so I will merge now 😄...

I think you will need to use `git webkit setup` and `git webkit pr` to make the pull request. It looks like your WebKit is forked from https://github.com/haiku/haikuwebkit rather than...

I see. I think you will need to clone *this* repo (https://github.com/WebKit/WebKit) and then run `git webkit setup` from inside there. Or is the issue that you cloned this repo,...

@aj062 @JonWBedard Any ideas what might be going on with the setup script in @nephele-gh's case?

@nephele-gh Feel free to upload the same patch on Bugzilla, whenever you are able to.

> I would have time now to upload it to bugzilla, I kind of forgot the process, and the doc has been replaced with the git one :D. Running `webkit-patch...

There are a couple more changes necessary for this to work with all uses of find-in-page on Cocoa platforms. To support iOS and the `UIFindInteraction` API: https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm#L11780 To support all...

> > To support iOS and the `UIFindInteraction` API: [`main`/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm#L11780](https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm?rgh-link-date=2024-03-01T21%3A32%3A14Z#L11780) > > To support all Cocoa platforms and `WKWebView`'s `findString:` API: > > https://github.com/WebKit/WebKit/blob/4f76c56c5655b26ed84f9f1b1d03a59c87e74885/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm#L1439 > > Thanks, pushed an amended...