Anton Smirnov comments

Results 213 comments of


                                            Anton Smirnov

AMDGPU.agents() doesn't see GPU

We now use much newer versions so this should be fine.

ROCM/Hip not downloading (?) when ]added

We now have better support for `gfx103x` other than `gfx1030`. Although now we mostly require system-wide installation of ROCm for full support.

Test of AMDGPU fails on 5900HX - hipErrorNoBinaryForGpu

Will close. Feel free to try with latest AMDGPU.jl.

Feature request: allow `hsa_amd_memory_copy_async` to pick a queue

We now support this with HIP version.

Segfault on ROCm 5.0

I think we can close it now as the issue has been resolved: - we now use correct ROCm & LLVM versions - alloca issue was also fixed

Use refcounting for memory management

We now have stream-ordered allocations and on top use the refcounting mechanism from GPUArrays. As well as `unsafe_free!`.

Implement copy!()

Scalar indexing no longer happens.

Preliminary fix for Base.unsafe_wrap

> which allocated new memory instead of wrapping over the passed pointer Can you show an example of when it allocated? Both `HostBuffer` and `HIPBuffer` when passed a pointer and...

Preliminary fix for Base.unsafe_wrap

I don't have any objections regarding these changes (as long as they work). `lock` keyword is more of a remnant from the HSA era. FYI, current implementation also does not...

Enzyme + KA Stalls on Error instead of reporting it

Hm... actually yes, just tried it on 1.10-beta2.