pwsafe icon indicating copy to clipboard operation
pwsafe copied to clipboard
verified publisher icon pwsafe

Upgrade macOS build to the new macos-14 runner

Open nobugshere opened this issue 1 year ago • 4 comments

This PR makes the following changes to the macOS yaml file:

  • Use the new macos-14 runner (required adding sudo to make install)
  • Xcode 15.2
  • wxWidgets 3.2.4
  • Use specific commit numbers for the Yubico products instead of the current HEAD, since they haven't added any tags in years.
  • Remove a macOS specific workaround (PR #1068)

nobugshere avatar Feb 09 '24 01:02 nobugshere

Hi,

This is still marked as a draft. Any progress?

ronys avatar Feb 23 '24 07:02 ronys

I'm just waiting to see if they remove the "Beta" designation from the macos-14 runner. Maybe they aren't going to do that until they move it to macos-latest, next quarter. Looks like they are still making changes to the included tools. https://github.com/actions/runner-images/issues/9255 https://github.com/actions/runner-images/pull/9380

In the mean time, I was thinking, at some point, I should rebase this branch to test the build with all the UI changes. What are your thoughts?

nobugshere avatar Feb 23 '24 19:02 nobugshere

No rush, just wanted to make sure this wasn't "orphaned". Rebase is probably a good idea.

ronys avatar Feb 24 '24 08:02 ronys

Rebased onto master commit 50815ab

nobugshere avatar Mar 01 '24 04:03 nobugshere

Rebase and separated some commits into their own PRs.

nobugshere avatar Mar 22 '24 01:03 nobugshere

The macos-14 runner image is GA as of today. I think this is ready to merge. https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/

nobugshere avatar Apr 01 '24 21:04 nobugshere

Thanks!

ronys avatar Apr 02 '24 06:04 ronys

Any idea when we can expect the release to be available?

seamusdemora avatar Apr 02 '24 06:04 seamusdemora

Hopefully late April / early May

ronys avatar Apr 02 '24 17:04 ronys

@ronys : Thanks for the information. Could I ask why this process takes so long?

seamusdemora avatar Apr 03 '24 03:04 seamusdemora

@seamusdemora - the process doesn't take long at all. My free time is the bottleneck here. If you wish, you can grab a dmg generated as an artifact from the latest mac-pwsafe workflow run (https://github.com/pwsafe/pwsafe/actions/workflows/macos-latest.yml) For example, https://github.com/pwsafe/pwsafe/actions/runs/8581201155 - click on the download icon in the lower right.

ronys avatar Apr 08 '24 06:04 ronys

Thanks! I'll try this.

seamusdemora avatar Apr 10 '24 08:04 seamusdemora