Migration to Teal with GitLab Support

Open l0nax opened this issue 3 years ago • 7 comments

Issue Description

Type: "feature request"

Describe what happened (or what feature you want)

Since I really love this plugin but mostly work with GitLab, I decided to start the migration to Teal allowing us to easily implement gitlab (or any other Host provider).

See #138

Since the code base is not small anymore, I did not migrate the whole project to Teal, instead, only the parts which are relevant for the implementation are migrated/ refactored.

Currently, only GitLab issues are implemented.

Apr 11 '22 13:04 l0nax

Hi @l0nax thanks for the PR. Can you elaborate on why gitlab provider cannot be supported in plain lua? Im ok adding support for GitLab or other providers but Im not considering migrating @

Apr 11 '22 18:04 pwntester

Hello there. I agree with @pwntester, the gitlab support should use the glab tool as backend, which is a non official gitlab cli, akin to gh cli. In fairness, I started looking at this because I use gitlab in my company and Octo is awesome. I'd love to work in that integration, WDYT @pwntester? Can I open a MR with some raw work to kick off some discussions?

Aug 06 '22 22:08 brendalf

Sure, that sounds great!

Aug 07 '22 13:08 pwntester

Glab is now officially adopted by GitLab. https://github.com/profclems/glab/issues/983

Sep 06 '22 02:09 sunzoje

Hi there. Sorry for taking so long. I will open the MR this weekend.

Nov 04 '22 18:11 brendalf

@sunzoje I already converted roughly about 70% of the code base to lua. I will push the changes this weekend.

Nov 04 '22 18:11 l0nax

Any update on this ?

Jan 20 '23 10:01 Daemoen