ReactiveNetwork icon indicating copy to clipboard operation
ReactiveNetwork copied to clipboard

Changed to not use NetworkInfo class for Lollipop and above

Open chaesung opened this issue 4 years ago • 9 comments

This PR introduces the following update:

Was concerned about issue #318

However I couldn't completely remove the NetworkInfo class in Connectivity class

I just changed it so that it would use the network callback api from Lollipop and above.

If you don't have time please give me some tips on how I should implement it or just dump in ideas in this PR.

I will try to work on it.

Hope to hear from you soon.

chaesung avatar Sep 17 '20 05:09 chaesung

Any feedback on this??

chaesung avatar Sep 22 '20 04:09 chaesung

Hi @chaesung.

Thanks for your PR. I didn't have time to perform the review of your code. I'll do it soon.

Regards, Piotr

pwittchen avatar Sep 22 '20 08:09 pwittchen

Code looks quite fine. Maybe small adjustments can be done after merge. I'll test it later and if everything will be ok, I'll merge it.

pwittchen avatar Oct 09 '20 08:10 pwittchen

@pwittchen Thanks for the approval. Would it be possible to know when it would be merged?

chaesung avatar Oct 12 '20 01:10 chaesung

@pwittchen any feedback on this?

chaesung avatar Nov 12 '20 05:11 chaesung

Has this been merged?

henryglendening-hh avatar Sep 02 '21 16:09 henryglendening-hh

Please merge it

jortas avatar Apr 18 '22 11:04 jortas

I checked out this branch after fixing test configuration and I see, several tests are not passing.

Unfortunately, we cannot see them here, because Travis CI were changed and this CI doesn't work anymore with old configuration. I need to fix this CI or migrate do GitHub actions...

From what I see, MarshmallowNetowrkObservingStrategy#propagateAnyConnectedState() method, needs and update to consider NetworkState besides NetworkInfo class to make it work properly and to make tests pass. You can try to fix it by yourself or I can take a look at it later.

pwittchen avatar Dec 04 '22 18:12 pwittchen

I took your PR and added some adjustments in PR #469 regarding library logic and tests. I need to verify that and maybe add some more tests for the newer Android API. If everything will be working fine, I'll merge it.

pwittchen avatar Dec 04 '22 20:12 pwittchen