shellcheck-plugin icon indicating copy to clipboard operation
shellcheck-plugin copied to clipboard

Configuration path to shellcheck is not stored properly

Open Vity01 opened this issue 6 years ago • 4 comments

Hello, first of all - thank you for the kick off this project. ShellCheck is very useful tool and this plugin helps a lot - especially for beginners... Whenever I open a new project, I get an error message window describing shellcheck path is not filled (through intellij idea event log). Could you please check the code for storing the configuration path?

-- IDEA 2017.3, ShellCheck plugin 0.1

Vity01 avatar Mar 07 '18 15:03 Vity01

I was trying to reproduce it and failed. Plugin configuration is stored per project and by default it is not enabled in new project, so I dont know how you do it. Please try to collect details steps, so I could find fix or alternatively propose PR.

pwielgolaski avatar Mar 10 '18 18:03 pwielgolaski

That was my note. The configuration is stored per project. I guess you don't need to specify shellcheck path for every single project. I work with tens of projects and it's annoying to set it for each one. It should be on IDE level.

Vity01 avatar Mar 13 '18 11:03 Vity01

First, great plugin. Thanks a lot Piotr.

I have the same issue, switching to new projects or if I clean some folders... the configuration for the project is lost. I have frequently to reenter the settings. Some plugins have a global configuration (on Windows menu File / Other Settings / Default settings then "Other settings" and I can see a few plugins with their default config here (FindBugs-IDEA, Lombok plugin, QAPlug.... The entry for your plugin is empty. (latest IDEA) If I could store the defaults here and when the project pops up just select the defaults in one click. Even better, they could automatically apply without any prompt and if you wanted to override them for this project then you would modify your project settings. Thanks

odupuy avatar May 15 '18 16:05 odupuy

it makes sense, I would be open for any PR to address this issue, if I find time I would try to get it done, but can promise that it will happen in near future.

pwielgolaski avatar Aug 19 '18 14:08 pwielgolaski