rebook
rebook copied to clipboard
pwang7
Just wanted to thank your efforts towards this project. Extremely useful. ❤️ 🚀 👍🏼
Could just be me not knowing how to use rebook/k2pdfopt well enough, but whenever I switch the device to different ereaders, resolution stays the same. I'm trying to put the...
When I'm choosing the margins in "Crop Margins (in)" like ``` Left : 1.00 Right : 1.50 Top : 3.0 Bottom : 0.1 ``` the generated command line looks like...
Following the k2pdfopt doc, there muse be a space between ocr_cpu_arg_name and the %, like this `-ocr -nt -50`. So I think there is a minor bug in your code...
The variable `entry_list` (https://github.com/pwang7/rebook/blob/master/rebook.py#L2070) is never used. ``` entry_list = [ inputPathEntry, outputPathEntry, cmdArgEntry, pageNumEntry, landscapePageNumEntry, currentPreviewPageNumEntry, ] ``` I think you can remove it
Hello, I see these line in your code (line 1701)… I think it can be deleted. ``` def load_image_to_canvas(photo_img, canvas): load_image_to_canvas(preview_img, previewImageCanvas) ```
On MacOS when I clic on the 'Open PDF file' button, I've the following warning: ``` 2021-08-24 11:44:57.825 Python[52152:29984241] WARNING: running implicitly; please run panels using NSSavePanel rather than NSApplication....
> Function and Variable Names > Function names should be lowercase, with words separated by underscores as necessary to improve readability. > Variable names follow the same convention as function...
I'va take the time to read all your code and I see you're using a lot of global variable: ``` global strvarCmdArgs global k2pdfopt_cmd_args global strvarOutputFilePath … ``` It's almost...