grunt-slack-hook icon indicating copy to clipboard operation
grunt-slack-hook copied to clipboard

Webhook URL is not valid anymore

Open YouriT opened this issue 10 years ago • 5 comments

Slack has changed incoming webhooks URL's, therefore, I would replace:

url = 'https://' + options.domain + '.slack.com/services/hooks/incoming-webhook?token=' + options.token,

by

url = options.endpoint ? options.endpoint : 'https://' + options.domain + '.slack.com/services/hooks/incoming-webhook?token=' + options.token,

To allow flexibility between every kind of endpoints ;)

YouriT avatar Dec 01 '14 15:12 YouriT

Created a PR for this #3

YouriT avatar Dec 17 '14 11:12 YouriT

Some changes has been done on my fork, I republished the plugin as grunt-slack-hook-task to npm, if you get back and include the changes I can remove it. I let you the credits in the package.json file...

See ya !

YouriT avatar Feb 05 '15 14:02 YouriT

@YouriT Thank you very much for publishing your fork officially. Funny Timing, was just starting to work on patching this up myself

EdHurtig avatar Feb 05 '15 18:02 EdHurtig

My pleasure @EdHurtig :)

YouriT avatar Feb 06 '15 10:02 YouriT

See #6 for a proper PR.

YouriT avatar Feb 11 '15 17:02 YouriT