PWABuilder icon indicating copy to clipboard operation
PWABuilder copied to clipboard

[BUG]

Open RenatoRolando opened this issue 1 year ago • 7 comments

What happened?

pswabuilder.com froozen in inspect this pwa ([https://circolari.quifederfarma.it/]) with webmanifest wrong

How do we reproduce the behavior?

  1. go. to website pwabuilder
  2. chech https://www.pwabuilder.com/
  3. this site have a wrong manifest.webmanifest (see below)

Check this website, actually I have the manifest.webmanifest like this, but I will change to fix it .

</html><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"/>
<title>404 - Impossibile trovare il file o la directory.</title>
<style type="text/css">
<!--
body{margin:0;font-size:.7em;font-family:Verdana, Arial, Helvetica, sans-serif;background:#EEEEEE;}
fieldset{padding:0 15px 10px 15px;} 
h1{font-size:2.4em;margin:0;color:#FFF;}
h2{font-size:1.7em;margin:0;color:#CC0000;} 
h3{font-size:1.2em;margin:10px 0 0 0;color:#000000;} 
#header{width:96%;margin:0 0 0 0;padding:6px 2% 6px 2%;font-family:"trebuchet MS", Verdana, sans-serif;color:#FFF;
background-color:#555555;}
#content{margin:0 0 0 2%;position:relative;}
.content-container{background:#FFF;width:96%;margin-top:8px;padding:10px;position:relative;}
-->
</style>
</head>
<body>
<div id="header"><h1>Errore del server</h1></div>
<div id="content">
 <div class="content-container"><fieldset>
  <h2>404 - Impossibile trovare il file o la directory.</h2>
  <h3>È possibile che la risorsa desiderata sia stata rimossa, che sia temporaneamente non disponibile o che il relativo nome sia stato modificato.</h3>
 </fieldset></div>
</div>
</body>
</html>

pwabuilder never send a report, stay 'frozen'

What do you expect to happen?

pwabuilder should report that the webmanifest is wrong

What environment were you using?

OS Sequoia 15.0, Chrome version 129.0.6668.60

Additional context

No response

RenatoRolando avatar Oct 01 '24 10:10 RenatoRolando

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@RenatoRolando I was testing your link, the webmanifest seems correct ✅ image

But your service worker is wrong ❌ image image

Still a different discussion about handling the "infinite loop" (or frozen if thats what you mean), in case you want to fix from your side... you need to have a valid service worker url.

maiconcarraro avatar Oct 08 '24 15:10 maiconcarraro

@maiconcarraro thank you for your precious help.

At present the pwabuilder, testing my pwa address, is still on 'infitine loop' and obviously doesn't report nothing. In my opinion is not a valid behavior: the correct solution from the website was report the problem as you present me. At least report that I don't have a service worker.

Renato

RenatoRolando avatar Oct 09 '24 04:10 RenatoRolando

Hey all! So the "infinite loading" is a bug on our end when a manifest is not able to be parsed. The problem here is, in your web manifest, you have a line commented out as my screenshot shows. Because of this, PWABuilder is not able to successfully parse the manifest as JSON leading to the issue. While the SW may have also been incorrect, that is not what was causing the issue here from what I can tell. @RenatoRolando , would you be able to update this manifest please to remove the commented line my screenshot points too and try again? I am going to keep this issue open anyways to address our UI issue here, but yeah Id love to be able to try your app again with the commented line removed (or un-commented out) image

jgw96 avatar Oct 10 '24 21:10 jgw96

@jgw96 Today I will remove the commented line on manifest. Thank for support. R

RenatoRolando avatar Oct 11 '24 05:10 RenatoRolando

@RenatoRolando hey! Any updates here?

jgw96 avatar Oct 15 '24 19:10 jgw96

Dear @jgw96 as I told you I have removed the comment line on manifest 5 and now works. I'm not able to see if still goes on 'infinity loop'. ;) Thanks

RenatoRolando avatar Oct 15 '24 19:10 RenatoRolando

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .