PWABuilder icon indicating copy to clipboard operation
PWABuilder copied to clipboard

Minor updates in the install component

Open vicb opened this issue 1 year ago • 2 comments

PR Type

  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)

Describe the current behavior?

Describe the new behavior?

  • Remove public visibility for consistency (public is the default)
  • Optimize SVG with SVG OMG

PR Checklist

  • [x] Test: run npm run test and ensure that all tests pass
  • [x] Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • [n/a] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

vicb avatar Jun 17 '24 10:06 vicb

Thanks vicb for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@microsoft-github-policy-service agree

vicb avatar Jun 17 '24 10:06 vicb

Hey @vicb , this component is actually not maintained anymore, and therefore I dont normally merge PRs for that component anymore either. We instead recommend https://github.com/khmyznikov/pwa-install which is maintained by a member of our team.

jgw96 avatar Jul 01 '24 15:07 jgw96