PWABuilder
PWABuilder copied to clipboard
pwa-builder
[PWABuilder.com] Add "Meta Quest compatible" checkbox
Fixes https://github.com/pwa-builder/PWABuilder/issues/3154.
See also https://github.com/pwa-builder/CloudAPK/pull/98.
Thanks FluorescentHallucinogen for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
@jgw96 @JudahGabriel This pull request is ready to review and merge. :wink:
Hey @FluorescentHallucinogen , thank you so much for this PR! We are just waiting on talking to Meta who we've been partnering with to create the current Meta Quest packaging service. Will keep you updated.
@amrutha95
We are just waiting on talking to Meta
FYI, I was in close contact with @jacobrossi and @pampas93 from the Meta team while developing the related pull request for Bubblewrap to ensure that generated APKs meet all requirements and successfully pass all server-side validations for publishing to App Lab and Oculus Store. I.e. this feature already implemented in Bubblewrap 1.18.0, and this pull request only needed for adding the corresponding UI to PWABuilder. It doesn't remove anything (e.g. ovr-platform-util) from PWABuilder (this can be done later in a separate pull request). So IMO currently there is nothing that prevents this pull request from being reviewed and merged. 😉
Hello @FluorescentHallucinogen , I tried using bubblewrap with the --metaquest flag and had a question:
Can the resulting TWA be used for the google play store as well? Or is it specifically for meta quest devices?
@amrutha95
Can the resulting TWA be used for the google play store as well?
Yes.
Or is it specifically for meta quest devices?
No.
Hi @FluorescentHallucinogen! While we really appreciate this contribution, we had a strategy discussion about this today and decided to keep our Meta Quest platform as is. We have a deep partnership with Meta who help us build on and maintain our existing service, and we would also like to keep packaging separate for Play Store and Meta Quest for now. Hope this makes sense!
decided to keep our Meta Quest platform as is
That makes sense to me. Because APK files generated by ovr-platform-util is just a few kilobytes in size.
But, again, this pull request doesn't remove existing ovr-platform-util integration!
This pull request just only exposes an option that already exist in bubblewrap.
These things can coexist perfectly together.
It would be very strange that the PWABuilder can't do what the bubblewrap (that is used in the PWABuilder under the hood) can do. 🤯
Hiding existing options from the UI doesn't make sense for me.
Moreover, bubblewrap can generate universal APKs that open TWA (Trusted Web Activity) on regular Android devices and open Meta Quest Browser on Meta Quest VR devices. APKs generated by ovr-platform-util work only on Meta Quest VR devices and can't work on regular Android devices.
So please give my pull request another chance. 😉
@PEConn @andreban @jacobrossi @pampas93 @phosiaz cc.
Hi @FluorescentHallucinogen ! To make sure I understand: This PR adds a checkbox to the android PWA creation flow that allows users to also make the apk Meta Quest compatible?
Could you add some screenshots and explain the updated flow the user will see?
@phosiaz
To make sure I understand: This PR adds a checkbox to the android PWA creation flow that allows users to also make the apk Meta Quest compatible?
Exactly!
Could you add some screenshots and explain the updated flow the user will see?
Here are the screenshots and the updated flow:
- The user selects the "Android" option. Note that the "Meta Quest" option is still available.
- The user can check the new "Meta Quest compatible" checkbox. Note that it's unchecked by default.
Got it, thanks for clarifying! This feature looks great, but since Meta Quest Store Packaging option is already present, we're not sure if adding another Meta Quest option embedded within Android is required. Developers currently can't upload PWAs to App Lab, so I think the developers who are creating PWAs will likely be prioritizing a specific OS already. We can always revisit this if we get more users requesting this feature later on :)
Developers currently can't upload PWAs to App Lab, so I think the developers who are creating PWAs will likely be prioritizing a specific OS already.
Quite the opposite in fact: for me, as a PWA developer, it's better to pack the PWA into a universal APK once. I don't want to create and test APK for each platform (Android, ChromeOS, Meta Quest) separately. It is contradicting the core PWA idea — cross-platform (write once, run everywhere).
If Bubblewrap provides such a feature, it could be in PWABuilder as well.
Moreover, this option looks like a minor tweak, disabled by default and hidden under the "All settings" spoiler.
The PWABuilder should give developers a choice! 🙌
Thanks @khmyznikov for sharing your perspective and glad to hear your interest in building PWAs for all platforms 😊 In that case, I think it's okay to merge this PR, since it's just adding an additional choice without changing the default
@amrutha95 Could you please reopen this pull request? :wink:
For reviewers: to work this pull request requires https://github.com/pwa-builder/CloudAPK/pull/98 be merged too.
@amrutha95 I can pull the branch down and check it out after our meeting
Hello @FluorescentHallucinogen, we are looking to merge this PR however, I am having some issues pulling this PR onto my own machine. Since there has been a major frontend overhaul on our site, we want to make sure that this is all still working visually, and that the API is still called properly with your new flag.
Would you mind reviewing this yourself and updating this PR if necessary to match the redesign.
Thanks again for your work!
@Jaylyn-Barbee
I've rebased this pull request and checked that everything works as intended. Ready to merge. ;)
Please also don't forget to merge and release https://github.com/pwa-builder/CloudAPK/pull/98 to make the new checkbox work. ;)
@Jaylyn-Barbee
we are looking to merge this PR
Do you have any idea of when this PR be merged? And how soon after merging will it be available on https://preview.pwabuilder.com and https://pwabuilder.com?
@FluorescentHallucinogen, we are working to make sure the backend component will be up to date to handle the new meta quest compatible option. @amrutha95 will be back here to update once that is complete. Once merged, it would be available in the following 10 minutes.