PWABuilder icon indicating copy to clipboard operation
PWABuilder copied to clipboard

[vscode] PWA Studio: Multi-folder workspace support

Open zateutsch opened this issue 3 years ago • 5 comments

Describe the bug Currently, the extension selects the first workspace folder as the root for managing the PWA.

See: code snippet

In these lines, vscode.workspace.workspaceFolders[0] always selects the first folder.

Expected behavior Multi-folder workspaces are compatible.

Possible solution: Detect # of folders, if 1, use it if > 1, have user select.

But not sure if this is practical in the extension API.

zateutsch avatar Feb 08 '22 06:02 zateutsch

Hello zateutsch, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

ghost avatar Feb 08 '22 06:02 ghost

Ahh yes good point. I will have to research this a little but then I can look when it makes sense. I am going to consider this a feature request. Thanks Zach! 😊

jgw96 avatar Feb 09 '22 03:02 jgw96

@nmetulev I see you added this to bugs today though. Is this a bug in your opinion? Totally fine if it is, I just didn't want to go "over your head" and make this a feature request lolol

jgw96 avatar Feb 09 '22 03:02 jgw96

Feature request makes sense to me. I don't often use multi-folder workspaces in code (does anyone?) but could be frustrating for those that do.

zateutsch avatar Feb 09 '22 07:02 zateutsch

Marked it as a feature request, @nmetulev let me know if thats not cool with you 😊

jgw96 avatar Feb 09 '22 21:02 jgw96