Pierre Walker
Pierre Walker
Oh, I forgot to mention. Our water model with the temperature-dependent sigma is actually called water08 and we only include the temperature dependence in a variant of PC-SAFT we call...
Yes these small differences are to be expected. I would recommend trying to compare lower-level functions. For example, we have an a_res function to give the reduced Helmholtz free energy...
Ah, I guess this is where we compare parameters 😅. You can get all of ours from the model object: ```julia model = ePCSAFT(["water"], ["sodium", "chloride"]) model.neutralmodel.params.epsilon model.ionmodel.params.sigma ``` if...
I didn’t realise you weren’t one of the maintainers of PC-SAFT on CoolProp. I only brought this up cause I know @ibell cares a lot about getting these things as...
No worries! The ion diameter issue was really annoying me for a while (especially considering how not-obvious it is). Glad we could get this sorted! Thanks a lot for the...
One thing to add: increasing the number of points does not remove these oscillations and doesn't change their amplitude.
Yep!
My apologies for not being clearer. I can get it to work for simple examples like the one you've shown. However, once calls to module functions are used, like `bubble_pressure`,...
Really weird... Although in the above, it still computed the function and _then_ timed-out. So it didn't do its job...
That's a pretty extreme case 😂