node-git-wrapper

node-git-wrapper copied to clipboard

Potentional security flaw

3

git-wrapper should never ever be used with unchecked values. It's currently not safe for productive usage and apparently was never intended for such a case. The way the arguments are...

Gottox

Use spawn instead of exec.

2

This way it's not subject to stdout maxBuffer restrictions that come with exec. Fixes issue #6

barwin

NPM says [git](https://www.npmjs.com/package/git-wrapper#installation) Readme says: [git-wrapper](https://github.com/pvorb/node-git-wrapper#installation) Should be the same.

gabipetrovay

`cwd` option is set in the constructor function, so it's impossible to pass this parameter to `exec` command every time it's needed. In this case I need to create `Git`...

Ann-Dederkal

child_process.exec limits stdout to 200k, throws exception when git command produces more than 200k of output

2

I'm trying to run some git commands using git-wrapper that generate more than 200k of output. They are hitting the maxBuffer limit of 200k from child_process.exec and throwing an exception...

barwin

options should default to an object not array

1

Isn't this wrong https://github.com/pvorb/node-git-wrapper/blob/88a604ec444e9ce220cc40f9e0948e62edff0394/git.js#L24 ? It should default to an empty object not an empty array.

rothshahar