Pedro de Medeiros

Results 31 comments of Pedro de Medeiros

> I don't like that you're adding special rules specifically for the DebuggableEditor windows. E.g. it would also be useful to use PgUp/PgDown in the disassmbly view, and many other...

> On each window creation you call "FindWindowByName()" that seems expensive. I have not checked, but I think the function "GetItemID()" will return the same result. At least when called...

> On each window creation you call "FindWindowByName()" that seems expensive. I have not checked, but I think the function "GetItemID()" will return the same result. At least when called...

I thought about what you said and here is my idea for next changes to this PR: 1) Separate HotKey class into a `EventListener` class (basically just `signalEvent` method) and...

I thought about a rather simple approach and implemented a solution based on it. It could be a temporary solution before we think about this complex layered widget event handling...

> I pushed [836528a](https://github.com/openMSX/openMSX/commit/836528a08a9c5eb2606a8535db46836eb9e10e35). That's basically a rework of this PR (very much inspired by it, but some aspects implemented slightly different). So now with this change what is the...

Closing this PR since the quest has evolved to https://github.com/openMSX/openMSX/pull/1601

Eh, I used the wrong example here. I think it would be useful for generated assembly code when you are generating code on the fly, so you are not expected...

Hi. I would like to tackle this problem.

Yes, but overwriting the shortcut for END doesn't work.