pvlib-python icon indicating copy to clipboard operation
pvlib-python copied to clipboard

Consider renaming x to y in bifacial functions

Open cwhanse opened this issue 2 months ago • 1 comments

The reference and local coordinate systems for bifacial functions align x to the East (reference) or along a tracker axis (local), and y to the North (reference) or perpendicular to the tracker axis and parallel to the ground. z is always Up.

Some bifacial functions, e.g., https://github.com/pvlib/pvlib-python/blob/6553710e8e87f0931846eba2abc6f21c19ebdadf/pvlib/bifacial/utils.py#L95, require a parameter x defined as "Position on the ground between two rows", or "Position on the row's slant length". In the coordinate systems, x corresponds to a distance in the y direction.

cwhanse avatar Oct 31 '25 15:10 cwhanse

a parameter x defined as "Position on the ground between two rows", or "Position on the row's slant length". In the coordinate systems, x corresponds to a distance in the y direction.

Those description sound like the position may not be measured along any of those three axes though...

The letter x does get used and abused rather a lot, poor thing!

adriesse avatar Oct 31 '25 16:10 adriesse