pvlib-python
pvlib-python copied to clipboard
Name field of modelchain.results.dc_ohmic_losses is i_mp, which is not correct
Describe the bug
name field of modelchain.results.dc_ohmic_losses
is i_mp
when it should be p_something
. I would suggest the name p_dc_ohmic_loss
.
To Reproduce Steps to reproduce the behavior:
- Run the following
import pvlib
from pvlib import pvsystem, modelchain, location
import pandas as pd
import sys
# Get a module parameters from the CEC database
MODULE = pvsystem.retrieve_sam('CECMod')['JA_Solar_JAM5_L__72_200_SI']
array_kwargs = dict(module_parameters=MODULE,
temperature_model_parameters=dict(a=-3.56, b=-0.075, deltaT=3),
array_losses_parameters=dict(dc_ohmic_percent=0.1))
mount = pvsystem.FixedMount(0, 180)
array = pvsystem.Array(mount, **array_kwargs)
loc = location.Location(40, -80)
system = pvsystem.PVSystem(arrays=[array], inverter_parameters=dict(pdc0=3))
mc = modelchain.ModelChain(system, loc,
aoi_model='physical',
spectral_model='no_loss',
dc_ohmic_model='dc_ohms_from_percent')
times = pd.date_range('2024-01-01 06:00', '2024-01-01 07:00', freq='5min',
tz='Etc/GMT+5')
weather = loc.get_clearsky(times)
mc.run_model(weather)
print(mc.results.dc_ohmic_losses.name)
Expected behavior
I would expect the name field of modelchain.results.dc_ohmic_losses
to reflect the nature of the data stored (e.g. ohmic loss power, not module maximum power current)
Versions:
python version= 3.12.1 (main, Dec 19 2023, 16:53:05) [GCC 10.2.1 20210110]
pvlib version= 0.10.3
pandas version= 2.2.0
Additional context Add any other context about the problem here.