Add optional `return_components` parameter to irradiance.haydavies
Update the Hay Davies sky transposition model to return individual components by user request.
- [ ] Closes #xxxx
- [x] I am familiar with the contributing guidelines
- [x] Tests added
- [x] Updates entries in
docs/sphinx/source/referencefor API changes. - [x] Adds description and name entries in the appropriate "what's new" file in
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`). - [x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
- [x] Pull request is nearly complete and ready for detailed review.
- [x] Maintainer: Appropriate GitHub Labels (including
remote-data) and Milestone are assigned to the Pull Request and linked Issue.
Thanks @spaneja this looks like a great start. In addition to fixing the stickler/pep8 stuff, can you make a note of the new functionality and add your name to the contributors list in the 0.9.4 what's new file (docs/sphinx/source/whatsnew/v0.9.4.rst)?
I'll take a closer look once the stickler issues are resolved, but one thing I notice now is that the (always zero) horizon component as mentioned in https://github.com/pvlib/pvlib-python/issues/1553#issuecomment-1270214826 is missing. Thanks!
Hearing no objections, I'll go ahead and merge this. Thanks again @spaneja