pvlib-python icon indicating copy to clipboard operation
pvlib-python copied to clipboard

Add in component sum equations for GHI, DHI, and DNI into the pvlib.irradiance module.

Open kperrynrel opened this issue 2 years ago • 1 comments

Right now, we have code for calculating GHI, DHI, and DNI via the component sum equations in pvlib/pvanalytics, and doing nighttime corrections (https://github.com/pvlib/pvanalytics/pull/163). @cwhanse and @kanderso-nrel suggested we port over the 3 component sum equations to the pvlib.irradiance module, and call them directly in pvlib/pvanalytics before applying a nighttime filter. This would require taking the guts out of pvlib.modelchain.ModelChain._complete_irradiance and creating a new function in pvlib.irradiance.

kperrynrel avatar Oct 03 '22 21:10 kperrynrel

Said differently: we're proposing to promote the ModelChain method _complete_irradiance to a public function in pvlib.irradiance.

cwhanse avatar Oct 03 '22 22:10 cwhanse