pvlib-python
pvlib-python copied to clipboard
Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches
- ~[ ] Closes #xxxx~
- [x] I am familiar with the contributing guidelines
- ~[ ] Tests added~
- ~[ ] Updates entries in
docs/sphinx/source/referencefor API changes.~ - ~[ ] Adds description and name entries in the appropriate "what's new" file in
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).~ - ~[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.~
- [x] Pull request is nearly complete and ready for detailed review.
- [x] Maintainer: Appropriate GitHub Labels (including
remote-data) and Milestone are assigned to the Pull Request and linked Issue.
This PR fixes several things:
- First, the ASV jobs have been failing since #1495 because
asvdefaults to callingsetup.pyand wasn't calculating the version string correctly anymore. This affected both our "quick" CI check and the nightly VM job. - Second, the "quick" CI check wasn't reporting those failures correctly to the github UI, so it showed up as a green check mark instead of a red X.
- Third, address @wholmgren's comment regarding the CI check for forks: https://github.com/pvlib/pvlib-python/pull/1454#discussion_r884026716