pvlib-python icon indicating copy to clipboard operation
pvlib-python copied to clipboard

Published 20 hours ago • verified publisher icon pvlib

Control tolerance for `assert_frame_equal`

Open cwhanse opened this issue 2 years ago • 1 comments

It would be nice to be able to supply atol and/or rtol to pvlib.conftest.assert_frame_equal.

For any pandas > 1.1, current behavior sets either atol, rtol = [1e-3, 1e-3] or atol, rtol = [1e-5, 1e-5]. If atol or rtol are specified they are silently ignored.

Describe the solution you'd like Pass atol and rtol through to pd.testing.assert_frame_equal

Describe alternatives you've considered Live with it and compute more accurate test solutions.

cwhanse avatar Jul 12 '22 00:07 cwhanse

NEP-29 says we can increase the minimum pandas to 1.1 and get rid of the test silliness.

wholmgren avatar Jul 14 '22 22:07 wholmgren