Christian Poveda Ruiz comments

Results 298 comments of


                                            Christian Poveda Ruiz

wrap_static_fns is missing from bindgen::Builder

I think that's because you're missing the `experimental` feature on your `bindgen` dependency.

wrap_static_fns is missing from bindgen::Builder

yeah this might have been an oversight. But the next version of bindgen won't require the `experimental` to use the feature.

Heapless 1.0

> Got some more issues addressed in https://github.com/rust-embedded/heapless/pull/547

support having `rust_target` track rust-toolchain.toml

I think it'd be great if we could always parse the right msrv from somewhere instead of having to set it up by hand. My only concern is that there...

feat: add custom attributes to `fn` items

:wave: I'd like to clarify some points here to (hopefully) avoid any confusion. So first of all, I understand your frustration as I've been several times in your position as...

Be pedantic about disrecommended practices

I'd do it just after the sudoers file is parsed. In that way, both `sudo` and `visudo` can throw a warning.

Is there a config that not pub out the func variable in struct when using dynamic loading?

There isn't but it shouldn't be to difficult to add (famous last words)

Avoid using \u{1} prefixes in symbol names where possible

hey Bjorn :) I'm all-in if we could replace this hacky solution for something less brittle. Is there something we could do before the `#[link_name("foo", verbatim)]` is actually implemented?

Improve readability of workflows

regarding bindgen, the current release is 0.72.0 and their changelog doesn't show any fix that could impact this project. The only slightly relevant one the way opaque types are handled,...

Failure to evaluate #define directives if they use values from defines passed through clang args

I suspect this might be `libclang`'s fault but I don't have any evidence of this yet.