Pierre Vanduynslager

Results 120 comments of Pierre Vanduynslager

To solve the situation described above where too many errors are printed in the output, should one just use Ctrl+C to stop the process? And if Ctrl+C doesn't work, maybe...

What would be the point of splitting the XO only and the ESLint config? Currently you can use any ESLint option in the XO config and it will be passed...

> Hmm, I'm leaning towards just removing bundle.js from default ignores. Agreed. > I would be in favor of just fixing it in Globby since that's easier than generally fixing...

Reopening per #435 I sent an email to IssueHunt to revert the reward

How should we correctly verify if we are running on a PR?

Can you fix the tests? See https://travis-ci.com/github/pvdlg/env-ci/jobs/489074757

What make you think it's related to not using `GH_TOKEN`? The error mention the branch is protected, so I guess it's related to a verification configured in the protected branch...

It seems the error happens based on how the repo was cloned... Not sure why. If that helps here is how semantic-release interact handle repo authentication: - Try to push...

It seems the action set the token in `.git/config`: https://github.com/actions/checkout/blob/f858c22e963bc60bc9d01c3d105c52a45a7deb6e/src/git-source-provider.ts#L264 In semantic-release we don't do that as we don't want to leave a token behind in a file on the...

> I just noticed that in our logs semantic-release outputs command: 'git push --tags https://github.com/{org}/{repo}.git HEAD:master-test' instead. That's expected. As I explained earlier: > If that helps here is how...