Bad system QXT usage

[tieugene]

As for Fedora 23 (patch):

--- CMakeLists.txt.orig	2016-11-21 08:42:04.383336108 +0300
+++ CMakeLists.txt	2016-11-21 08:53:32.542751207 +0300
@@ -59,7 +59,7 @@
 find_package(Qt5LinguistTools REQUIRED)
 
 if (USE_SYSTEM_QXT)
-    find_package(Qxt)
+    find_package(Qxt REQUIRED COMPONENTS QxtCore, QxtGui)
     message(STATUS "Use system Qxt Library: " ${USE_SYSTEM_QXT})
     if (USE_SYSTEM_QXT AND NOT QXT_FOUND)
         message(FATAL_ERROR "System Qxt not found")
@@ -180,6 +180,11 @@
 )
 if (NOT QXT_FOUND)
     include_directories(${CMAKE_CURRENT_SOURCE_DIR}/qxt)
+else ()
+    include_directories(
+        ${QXT_INCLUDE_PATH}/QxtCore
+        ${QXT_INCLUDE_PATH}/QxtGui
+)
 endif (NOT QXT_FOUND)

[palinek]

Sorry, but the provided "patch" is dealing with something rather outdated. There is no such source in current master or the 5.0.0 release.

[tieugene]

This patch is about 5.0.0. Look at this: http://koji.fedoraproject.org/koji/taskinfo?taskID=16550598

[palinek]

Please, point us to the source file/line here in the github (or even submit a pull request), as I don't see it here.

[tieugene]

O, sorry. As about current sources (CmakeList.txt):

• Line 63: r/find_package(Qxt)/find_package(Qxt REQUIRED COMPONENTS QxtCore, QxtGui)/
• Line 183: insert: else () include_directories( ${QXT_INCLUDE_PATH}/QxtCore ${QXT_INCLUDE_PATH}/QxtGui )

[palinek]

Sorry, the markdown interpretation of your diff pasted into gitbub message was rather confusing. (I've updated your first post)

[tieugene]

I see. It's impossible to attach *.diff to issue.

[palinek]

I see. It's impossible to attach *.diff to issue.

Yes, because that's a PR :)