skills
skills copied to clipboard
Skills-Search rework: Bugfixes after rework
Before the rework the people skill search had the following known bugs. After the rework investigate if these bugs still occur and fix them if they do.
- When adding the first new row and the default row has no value selected, the dropdown in the default row is automatically set to the first value of the dropdown.
- When selecting the same skill twice no results are found.
- The turboframes we utilize (one for the search filters and one for the results) dont seem to work, since updating the slider for the skill level triggers a page refresh.
- Only relevant if the upgrade to Rails 8 is already merged: The update from Rails 7.1 to 7.2 introduced flaky specs. The
fill_out_rowmethod in the specpeople_skill_searchsometimes fails to update the slider in firefox. - When a new row is added and the values of this row (e.g. level) are changed, the row vanishes.
- The styling is a bit off. The newly added rows are not aligned with the default row:
ToDo
- [ ] Fix bugs that are described above if they still occur
- [ ] Do a thorough smoke tests and if you find new bugs also fix them
- [ ] Add specs that check for these issues