skills icon indicating copy to clipboard operation
skills copied to clipboard
verified publisher icon puzzle

Adopt Puzzle Shell

Open hupf opened this issue 11 months ago • 7 comments

With the Puzzle Shell, we have a standard design for our tools & solutions – many other project already use it:

https://github.com/puzzle/puzzle-shell

We should adopt Puzzle Shell as the base layout for Puzzle Skills to achieve a unique look over the various apps. I'd also be happy to support, if needed...

hupf avatar Feb 04 '25 12:02 hupf

We did kind of use it at one point and it is still included and works: https://github.com/puzzle/skills/blob/4a5efbcdd34bf5b85650f959ead9e9d41f372e1b/app/views/layouts/application.html.haml#L12 https://github.com/puzzle/skills/blob/4a5efbcdd34bf5b85650f959ead9e9d41f372e1b/app/views/layouts/application.html.haml#L63

However, last time we wanted to use it for the applications' header we struggled to make it work properly and decided that it wasn't worth the effort. The focus back then was on just making the application work again without EmberJS.

As the application is now in relatively stable state, revisiting this seems like a reasonable suggestion to me.

It certainly won't be a priority over the more functional features but we'll see how far we get.

Robin481 avatar Feb 04 '25 12:02 Robin481

TODO:

  • See for which components we can use the PuzzleShell
  • Implement the easy ones in a 8h Timebox
  • Create follow up tickets for the other ones
  • Ask @hupf for help if need be 😸

Robin481 avatar Mar 10 '25 06:03 Robin481

@Robin481 The Puzzle Shell only includes components for the base layout (header/footer) and navigation. It works just fine with whatever you got (Bootstrap etc.). Please reach out if I can help in any way... I can also support you with the basic shell markup if you like...

hupf avatar Mar 10 '25 07:03 hupf

Todo's

  • [ ] See for which components we can use the PuzzleShell
  • [ ] Implement the easy ones in a 8h Timebox
  • [ ] Create follow up tickets for the other ones

Timeboxed 8h

nevio18324 avatar Mar 11 '25 09:03 nevio18324

Stand 11.3

I Started to try and implement some templates we could use and created a sub-issue for header and banner because the puzzle shell could be handy there

nevio18324 avatar Mar 11 '25 14:03 nevio18324

Stand 13.3

I updated the Header banner ticket and started to create a footer using the puzzle shell the footer is close too finished he just currently isnt really centered

nevio18324 avatar Mar 13 '25 14:03 nevio18324

Stand 17.3

I now created these 2 Tickets one for Header and Banner and one for the Footer

And i did some work on the footer to see if its doable / makes sense

nevio18324 avatar Mar 17 '25 08:03 nevio18324