Update PTime API | PuzzleTime Sync #5
Introduction At the moment, the PuzzleTime API doesn't provide us with all the data necessary to create a new Person if we need to. To be able to do this, a few new fields need to be added to the API. These fields are:
- city
- birthdate
- nationality
- active member flag
We also have noticed, that we get a field with employment_roles from the API, which is an array, but it is always empty. Take a look at what it is, if it is broken somehow and if it maybe even is helpful for us.
ToDo
- [x] Fork PuzzleTime repo if you dont have access and setup the project locally
- [x] Add all missing fields to the /api/v1/employee endpoint of PTIme
- [x] Check the /api/v1/employee/1 endpoint, it should return the correct data
- [x] update Tests
- [x] Create PR on PuzzleTime repo
@ManuelMoeri FYI
Since the building of the PTime PR #244 had some issues, I've applied it in the PTime commit 3cac154
PuzzleTime API has been updated successfully. Therefore this ticket can be closed.