Giovanni Bucci

Results 36 comments of Giovanni Bucci

I am willing to work on this, but I am a little confused about one aspect: should I remove ALL the local IPV6 links from `addresses` in `onlookupall` or just...

> You often have more than one ipv6 address, this is pretty normal. So all link-local ones should be skipped, not just the first one. that's what I thought as...

I am struggling with automated tests: the function is working fine, but I noticed that the DNS resolution is actually real and not mocked anywhere (at least I could not...

> IIRC isn't there a PR already open doing this? > > Maybe one or the other should be closed in favor? yeah I noticed, but I pushed mine forward...

> @puskin94 the PR changes the `test_runner` submodule, so the first commit message should be prefixed with `test_runner` and not `lib`. Could you please rebase and fix the message? Let...

Can anyone help me out here? I see the PR is stuck and I guess it is because of broken jenkins tests... I tried to reproduce them but everything is...

Is this MR waiting for something else before "Landing" ? I am reading the docs and it looks like I have all the required steps? Or am I missing something?

Asking the future reviewer to re-trigger the pipeline due to flaky tests 😄

@H4ad thanks for taking a look! I have just pushed to update the documentation!

@H4ad I had to update `test/common/benchmark.js`'s regex to allow multiple lines from the output because now we have cases like this: ```shell http/end-vs-write-end.js http/end-vs-write-end.js duration=0.05 method="write" c=1 len=1 type="asc" benchmarker="test-double-http":...