OpenVR-SpaceCalibrator icon indicating copy to clipboard operation
OpenVR-SpaceCalibrator copied to clipboard

Ability to grab and offset space to do fine adjust.

Open sidequestlegend opened this issue 4 years ago • 4 comments


name: Ability to grab and offset space to do fine adjust. about: I suggest this a potential solution to #15 without the need to use an extra tracker. I'm a decent coder and I would love to do a PR but i cant write cpp. I would love to know your thoughts.

So the idea would be a 2 handed grab that would let you rotate and translate the space to fine adjust the calibration. title: 'Ability to grab and offset space to do fine adjust. ' labels: enhancement assignees: ''


sidequestlegend avatar Nov 12 '20 21:11 sidequestlegend

Just another comment on this as well as some more background. I'm using Oculus Quest with Vive trackers so it suffers from bad drift as the space re-aligns. I feel this solution could possibly make it much quicker to calibrate rather than having to wait the 10-15 seconds for it to capture the samples during calibration. I think on the edit calibration screen this could fit quite nicely, that while on that screen you could use the grips to grab the openvr tracking space and offset it ( kinda like you were putting on a pair of trousers ).

Looking at the code its actually a lot more straightforward than some of the c++ im used to seeing so i might attempt a PR here. Please let me know what is the best way to run the dev stack and if you would be open to such a PR.

Here is my changes incase you are interested, this is untested at time of writing - https://github.com/pushrax/OpenVR-SpaceCalibrator/pull/37

sidequestlegend avatar Nov 13 '20 11:11 sidequestlegend

We've discussed this feature on Discord before, I think it would be a good inclusion.

You should be able to open the .sln file in Visual Studio 2015 or 2017 and just build without any dependency setup. The project is currently set up for v140 build tools (VS 2015), but 2017 should be able to automatically migrate it to v141 (VS 2017). I should migrate it all over to 2019, but just haven't yet.

Since you don't need to make changes to the driver, for running your own build you can open SteamVR, close OpenVR Space Calibrator that's automatically launched, and then launch in Visual Studio.

pushrax avatar Nov 13 '20 18:11 pushrax

Awesome! Ive got a start in https://github.com/pushrax/OpenVR-SpaceCalibrator/pull/37 I hope to finish it off by tomorrow

sidequestlegend avatar Nov 13 '20 22:11 sidequestlegend

Hey! So an update on this. I now have the ability to grab and offset the target tracking space using the reference controller with the grip pressed ( with some caveats ) - this is already pretty useful though and I am already using it with my setup.

What I can't seem to figure out is the correct rotation calculation for it to make sense to grab/rotate the space. If you had any insight on this, it would be much appreciated, I have left my attempts commented out in case its useful, but I suspect pretty far from grasping the math involved. I would love to have a chat about this in terms of the afore mentioned caveats and the overall implementation of what I'm trying to do.

https://github.com/pushrax/OpenVR-SpaceCalibrator/pull/37

sidequestlegend avatar Nov 15 '20 15:11 sidequestlegend