react-native-network-info icon indicating copy to clipboard operation
react-native-network-info copied to clipboard

getBroadcast() could be null in android on some interfaces

Open xmeow opened this issue 6 years ago • 8 comments

    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.net.InetAddress.toString()' on a null object reference
        at com.pusherman.networkinfo.RNNetworkInfo.getBroadcast(RNNetworkInfo.java:63)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
        at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:160)
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:754)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
        at android.os.Looper.loop(Looper.java:163)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
        at java.lang.Thread.run(Thread.java:760)

A possible fix would be add some check to broadcast address

    @ReactMethod
    public void getBroadcast(/*@NonNull String ip, */final Callback callback) {
        String ipAddress = null;

        for (InterfaceAddress address : getInetAddresses()) {
            if (!address.getAddress().isLoopbackAddress()/*address.getAddress().toString().equalsIgnoreCase(ip)*/) {
                InetAddress broadCast = address.getBroadcast();
                if (broadCast != null){
                    ipAddress = broadCast.toString();
                }
            }
        }

        callback.invoke(ipAddress);
    }

xmeow avatar Jul 14 '18 07:07 xmeow

also seeing the same issue when running on GenyMotion Emulator

07-17 00:19:44.076  8432  8473 E unknown:ReactNative: Exception in native call
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.net.InetAddress.toString()' on a null object reference
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at com.pusherman.networkinfo.RNNetworkInfo.getBroadcast(RNNetworkInfo.java:63)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at java.lang.reflect.Method.invoke(Native Method)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:160)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at android.os.Handler.handleCallback(Handler.java:789)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at android.os.Handler.dispatchMessage(Handler.java:98)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at android.os.Looper.loop(Looper.java:164)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
07-17 00:19:44.076  8432  8473 E unknown:ReactNative: 	at java.lang.Thread.run(Thread.java:764)

meylor avatar Jul 17 '18 00:07 meylor

+1

GabrielDuarteJr avatar Aug 09 '18 19:08 GabrielDuarteJr

Any news on this issue? Get this error on Xiaomi Note 4X with Android 7: screenshot_2018-12-17-14-11-50-618_com mrcat_waiter

fotonmoton avatar Dec 17 '18 12:12 fotonmoton

Any news on this issue? Get this error on Xiaomi Note 4X with Android 7: screenshot_2018-12-17-14-11-50-618_com mrcat_waiter

me too

Sanjeet1 avatar Dec 19 '18 09:12 Sanjeet1

me too on huawei p10

hevili avatar Feb 02 '19 07:02 hevili

me too!!

JerryLinyong avatar Feb 14 '19 02:02 JerryLinyong

+1 please fix!

shynst avatar May 13 '19 14:05 shynst

same error here, fix it guys pls.

pjunior94 avatar Jun 11 '19 20:06 pjunior94