pusher-http-php icon indicating copy to clipboard operation
pusher-http-php copied to clipboard

Added the possibility of passing query params to the getPresenceUsers

Open HenriqueSPin opened this issue 2 years ago • 1 comments

Description

Added the possibility of passing query params to the getPresenceUsers and the (deprecated) get_users_info in order to support the feature implemented by Soketi, and, hopefully, Pusher, where we can add a with_user_info=1 to this endpoint.

https://github.com/soketi/soketi/pull/450

The addition is retro compatible and does not impact current implementations.

CHANGELOG

  • [CHANGED] Added an optional param to the getPresenceUsers and get_users_info, the first parameter is the channel name (as of now) and the second optional parameter is an associative array with query string parameters.

HenriqueSPin avatar Apr 12 '22 14:04 HenriqueSPin

Looks good. I'll merge it soon. Thank you!

EDIT: Approved too fast without full context. We don't actually take extra parameters on this endpoint. This doesn't seem to make sense right now.

sonologico avatar May 23 '22 13:05 sonologico

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

stale[bot] avatar Sep 08 '22 23:09 stale[bot]