chatkit-client-js icon indicating copy to clipboard operation
chatkit-client-js copied to clipboard

Published 20 hours ago • verified publisher icon pusher

Typescript Implementation

Open craftycodie opened this issue 5 years ago • 11 comments

Changes

I've added types to all source files in this project, with some small changes to method signatures, and mistypes/unused variables.

Solves #69

craftycodie avatar Jun 17 '19 09:06 craftycodie

This is now ready for review, however it is not ready to merge. I would like some guidance regarding @Pusher's typescript configuration preferences, and general feedback would be great too.

craftycodie avatar Jun 18 '19 20:06 craftycodie

If anyone is interested in helping, there's a few cases where I've used explicit anys in some internal functions. As far as I can tell, I can't type web requests, as the pusher platform doesn't have types for them. But some of the ramda functions can be typed, I've just skipped them because they're not public facing and I don't fully understand them.

craftycodie avatar Jun 19 '19 11:06 craftycodie

Just wanted to let you know that we've seen this and will take the time to give it a proper look as soon as we get the chance. Looks really promising though, thanks! 😄

callum-oakley avatar Jun 21 '19 14:06 callum-oakley

@Alex-231 thank you for an enormous job you have done!

@callum-oakley are you planning to merge this pull request anytime soon? If yes, do you have an ETA? This PR is very important for us, we are evaluating multiple chat solutions right now. Not having typings could be a deal-breaker.

MaratFM avatar Jul 10 '19 15:07 MaratFM

@Alex-231 thank you for an enormous job you have done!

@callum-oakley are you planning to merge this pull request anytime soon? If yes, do you have an ETA? This PR is very important for us, we are evaluating multiple chat solutions right now. Not having typings could be a deal-breaker.

Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client

craftycodie avatar Jul 10 '19 16:07 craftycodie

Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client

Thank you @Alex-231, will give it a try. Did you generate typings from the code in this pull request?

MaratFM avatar Jul 10 '19 19:07 MaratFM

Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client

Thank you @Alex-231, will give it a try. Did you generate typings from the code in this pull request?

Yeah

craftycodie avatar Jul 12 '19 08:07 craftycodie

This would be great!

stfny222 avatar Jul 12 '19 22:07 stfny222

@codieradical: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pusher-ci avatar May 28 '20 17:05 pusher-ci

@codieradical: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pusher-ci avatar May 28 '20 17:05 pusher-ci

Pulled the changes to quickly review the conflicts, it's too much for me to do right now. Might get back to this in a month or two.

craftycodie avatar May 28 '20 17:05 craftycodie