James

Results 447 comments of James

I agree, this flag is useful for the most common scenario where there aren't recursive references.

I think it would be better as a separate `dinit` resource. Feel free to write one if you want it, I'm happy to merge, however I don't have any short...

Neat! Thanks for your patch. Looks like a good base. There are a few stylistic things to review, and some structural ones. Firstly, please have a quick look at the...

Feel free to ping if you have more questions about structuring all this...

> Sure, is that done anywhere else in the code base, namely passing in a context? Indeed, one example is: https://github.com/purpleidea/mgmt/blob/master/lang/core/os/readfile_func.go#L112 for example. It's more complicated because you have to...

One last thing: Let's briefly discuss what API we want... This does more than is_virtual... Do we want this all in one function? In two separate?

> If we don't want network calls made though I can rip it out. The 1st priority is correct data. The 2nd is good API The 3rd is speed. So...

> What privileges or capabilities will this function execute with? Whatever the user runs mgmt as. Classically root, but it turns out you can get pretty far with Linux capabilities...

FYI: I have merged a change in the simple function API that passes in a `context` so that it's now safe to write code that might need to be cancelled....