James

Results 371 comments of James

> Can you assign this to me. No need to assign anything, just send a patch and we'll be happy to review it.

I've patched this in f92f34dc549774a1f47c1993e560145fa53197db but if there is a better solution I'd love to have it.

https://github.com/pin/tftp/blob/90a06610acdd87d99706c4ea8328b60a04d9a8e7/server.go#L144 As an aside, we should test the latest version since there is some new cancellation code in Shutdown(). But if a client was reading a super huge file, we'd...

I've pushed some non-working initial code and a bunch of tests which I think are correct. (Fixes/changes welcome!) https://github.com/purpleidea/mgmt/tree/feat/include-class-scope The lexer/parser stuff is correct AFAICT. I think it's just the...

@gelisam So I've been writing a lot of the ordering code... I seem to have fixed at least the basic ordering stuff. For this example: ``` -- main.mcl -- #...

> So, what's the plan? Are you implementing this ticket while I switch to whatever's the next priority thing? Or am I taking over this ticket? I was a bit...

I am cleaning up the tests and the code... This popped out (new test)... ``` $x = "i am x" # i am top-level class c2() { $z = "i...

(But this is actually not trivial... _should_ we be able to shadow this? Hmmm....)

Secondly I have an ordering bug: ![graphviz-ordering dot](https://github.com/purpleidea/mgmt/assets/135091/80813e15-ac2b-40de-b9cc-34779f91da8b) > interpret_test.go:893: test #86: could not set scope: variable f1.x2 not in scope This happens some of the time. Presumably because the...

> $tmpx depends on $x which depends on $tmpx. Seems circular to me. Since the $x = "i am x" at the top is shadowed by the $x inside the...