James comments

Results 371 comments of


                                            James

[LOVE] Add Makefile "tab completion" for golang tests

@aequitas Good point which I hadn't considered.

[LOVE] Add Makefile "tab completion" for golang tests

@gedw99 I've heard of the project, but it's not a priority for me. `GNU Make` is used because it's universal, and easily available on every machine and is a good...

[LOVE] Add Makefile "tab completion" for golang tests

On Tue, May 22, 2018 at 3:55 PM, gedw99 wrote: > I should try gnu make on windows then !! Let us know how it goes! See: https://github.com/purpleidea/mgmt/blob/master/docs/faq.md#does-this-support-windows-osx-gnu-hurd Cheers!

[LOVE] Add automatic link checking to our docs

Maybe we should use https://github.com/raviqqe/muffet instead?

Using a version string for package state does not work

There was another casual report that showed some recent issues with `pkg` on Ubuntu... I am wondering if something changed in packagekit which broke this for you?

Using a version string for package state does not work

@Vanders Can you please try adding this line: > allowunsupported => true, Inside the `pkg` resource and tell me if it fixes the problem? Can you also confirm which repo...

engine: resources: Add reversible ability to the docker res (WIP)

If you rebase to current master, the builds should be fixed now.

imports: Use golang.org/x/sys/unix in place of syscall where possible

Sweet... Before I review, I should mention this will fail CI because of the commit format.

imports: Use golang.org/x/sys/unix in place of syscall where possible

commit message titles must be in the form: topic: Capitalized message with no trailing period

imports: Use golang.org/x/sys/unix in place of syscall where possible

@mfossen Assuming this passes tests, then LGTM =D Thanks! (I added one nit which you can change if you're in the mood, but it's not mandatory. More of a style...