pso-csi icon indicating copy to clipboard operation
pso-csi copied to clipboard

Make creating the secret optional

Open gaima8 opened this issue 3 years ago • 3 comments

Same as https://github.com/purestorage/helm-charts/pull/258 but for the newer release.

My aim is to have the flux helm-controller install the chart, and it's impractical to pass the API tokens securely for the chart to create the secret. A sealed-secret solves the problem of getting the values in but the chart will at best overwrite the unsealed secret.

I am very much open to ideas on how to handle the validation of arrays better.

gaima8 avatar Apr 08 '21 21:04 gaima8

@Pure-AdamuKaapan Is this change going to mess up the helm schema?

sdodsley avatar Apr 19 '21 17:04 sdodsley

@sdodsley I think this would make it so that arrays is no longer required (obviously). I think this would still validate that the array structs are well formed if they're there but we should confirm that locally to be sure

Pure-AdamuKaapan avatar Apr 19 '21 17:04 Pure-AdamuKaapan

Hi, requested changes to the README made.

gaima8 avatar Apr 20 '21 10:04 gaima8